Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] - Updates to GH actions workflows #1641

Merged
merged 5 commits into from
Feb 28, 2022
Merged

[MAINT] - Updates to GH actions workflows #1641

merged 5 commits into from
Feb 28, 2022

Conversation

trallard
Copy link
Member

@trallard trallard commented Feb 28, 2022 •
edited
Loading

  • 👷 [MAINT] - Use concurrency in GH actions: right now I have set it so that new runs on a given workflow cancel any other runs (for the same workflow)
  • 👷 Disable schedule for forks - I always get notifications that some workflows failed so this improvement prevents scheduled actions from running on forks

Closes #1540

@trallard trallard added the type:Maintenance A proposed enhancement to how we maintain this project label Feb 28, 2022
consideRatio
consideRatio approved these changes Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for your work @trallard, I appreciate the inline comments!!

@consideRatio consideRatio merged commit 69277bb into jupyter:master Feb 28, 2022
@trallard trallard deleted the trallard/actions-concurrency branch March 15, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

@mathbunnyru mathbunnyru mathbunnyru approved these changes

Assignees
No one assigned
Labels
type:Maintenance A proposed enhancement to how we maintain this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci maintenance: queue workflows or jobs with new GitHub workflow concurrency option?
3 participants
@trallard @consideRatio @mathbunnyru